Don't allow user to set updated_at columns for account - Githubissues

research-software-directory / RSD-as-a-service

This repo contains the new RSD-as-a-service implementation

https://research.software

23 stars 15 forks source link

Don't allow user to set updated_at columns for account #1090

Closed ewan-escience closed 7 months ago

ewan-escience commented 7 months ago

Don't allow user to set updated_at columns for account

Changes proposed in this pull request:

Silently reset the agree_terms_updated_at and notice_privacy_statement_updated_at columns when a user changes this in the account table.
Add a test for this and refactor some older tests
Update dependencies of the backend tests
Add a line to the docs explaining to add the setup class

How to test:

Inspect the test to see if it does what it is supposed to
Build and run the tests: make run-backend-tests

I'm not entirely sure if silently overwriting is better than generating an error. If someone has a good argument for the latter, I might change it.

PR Checklist:

[ ] Increase version numbers in docker-compose.yml
[x] Link to a GitHub issue
[x] Update documentation
[x] Tests

sonarcloud[bot] commented 7 months ago

Quality Gate passed for 'rsd-database'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud