fix: deduplicate maintainers on frontend - Githubissues

research-software-directory / RSD-as-a-service

This repo contains the new RSD-as-a-service implementation

https://research.software

23 stars 14 forks source link

fix: deduplicate maintainers on frontend #1102

Closed ewan-escience closed 8 months ago

ewan-escience commented 8 months ago

Deduplicate maintainers

Changes proposed in this pull request:

Deduplicate maintainers by using the login info with most present fields of name, email and affiliation

How to test:

docker compose down --volumes && docker compose build --parallel && docker compose up --scale data-generation=0
Log in with a non-ORCID account and create a software page, project page and organisation (make sure you're a maintainer of this organisation)
Couple an ORCID to this account
Check the maintainers of the pages you created above; only one maintainer should be visible on each

Closes #1091

PR Checklist:

[ ] Increase version numbers in docker-compose.yml
[x] Link to a GitHub issue
[ ] Update documentation
[ ] Tests

sonarcloud[bot] commented 8 months ago

Quality Gate passed for 'rsd-frontend'

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
29.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud