Closed ewan-escience closed 5 months ago
Failed conditions
27.8% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)
See analysis details on SonarCloud
Catch issues before they fail your Quality Gate with our IDE extension
SonarLint
Just for the protocol: using this implementation, the LinkOrcid button only is shown if
ORCID_REDIRECT_COUPLE
is defined.
That is correct. We can apply additional logic in the apiLinkOrcidProps methods if needed.
It is good to write down here that this PR now also contains caching.
Fix ORCID requests
Changes proposed in this pull request:
'MISSING'
withnull
if coupling URL is missingHow to test:
docker compose down --volumes && docker compose build --parallel && docker compose up --scale data-generation=0
Note: It would be better to only fetch the data when needed when clicking the button, or asynchronously in the background. It might also be good to use caching. However, this PR only implements the minimum necessary, as this code is also being worked on in #1100.
Closes #1103
PR Checklist:
docker-compose.yml