research-software-directory / RSD-as-a-service

This repo contains the new RSD-as-a-service implementation
https://research.software
22 stars 15 forks source link

974 improve maven scraper #1116

Closed ewan-escience closed 5 months ago

ewan-escience commented 5 months ago

More package manager scrapers

Changes proposed in this pull request:

How to test:

Closes #974 Related to #1081

PR Checklist:

sonarcloud[bot] commented 5 months ago

Quality Gate Failed Quality Gate failed for 'scrapers'

Failed conditions
13.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed for 'rsd-frontend'

Issues
0 New issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

jmaassen commented 5 months ago

Small question: looking at the code, it seems the frontend needs to know which scrapers there are and what data they produce. It has a has coded list of scrapers and fields like dependents and/or downloads. Wouldn't it be easier in the long run if this solution was more modular and allowed the backend to simply provide a list to the frontend of scraper configs?

ewan-escience commented 5 months ago

We could co that, but it would require us to setup some server with this info. If it becomes a problem later, we can have another look.