research-software-directory / RSD-as-a-service

This repo contains the new RSD-as-a-service implementation
https://research.software
23 stars 14 forks source link

improve software categories #1143

Closed fembau closed 4 months ago

fembau commented 6 months ago

How to test:

see #984

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed for 'rsd-database'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

fembau commented 4 months ago

Implementation of table representation is moved into another PR to speed up community feature PR

dmijatovic commented 4 months ago

@fembau To fix failing unit test please add empty categories array to frontend/__tests__/__mocks__/softwareIndexData.js

const softwarePageData = {
  slug: 'test-slug',
  software: softwareItem,
  citationInfo: SoftwareCitationItems,
  keywords: apiKeywordsBySoftware,
  licenseInfo,
  repositoryInfo: repoInfo,
  mentions: apiMentions,
  testimonials: apiTestimonial,
  contributors: apiContributors,
  relatedTools: apiRelatedSoftware,
  relatedProjects: apiRelatedProjects,
  isMaintainer: false,
  organisations: apiOrganisationsOfSoftware,
 // add categories to mock data
  categories:[]
}
sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed for 'rsd-database'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed for 'rsd-frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
12.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud