Do not show software highlights section when javascript is disabled

research-software-directory / RSD-as-a-service

This repo contains the new RSD-as-a-service implementation

https://research.software

22 stars 15 forks source link

Do not show software highlights section when javascript is disabled #1158

Closed dmijatovic closed 1 week ago

dmijatovic commented 3 months ago

Software highlights section uses Javascript for scroll navigation between items. When javascript is disabled complete section should not be hidden. Currently only title is shown without any functionality (see image)

ewan-escience commented 2 months ago

The only reason this is not server side rendered is because in the file frontend/components/software/overview/highlights/HighlightsCarousel.tsx, the left padding is calculated on the client (see the variable distance). @ctwhome is there a way we can do with e.g. CSS only?

dmijatovic commented 1 week ago

This issue is handled in #1195 by not showing the software highlight section when JS is diasbled (see image). Css class is created hide-on-no-script to hide components that require javascript.