cmeessen commented 2 months ago

Dedicated highlights page

Fixes #1170

Changes proposed in this pull request:

adds a dedicated page for software highlights
the highlights are by default sorted "Latest featured", i.e. ascending position
the filters in the sidebar show only properties of the highlights
the software highlights page can be reached via a button below the highlights carousel
note that the configuration for software highlights in settings.json changes slightly

How to test:

optionally: define software_highlights title and description in settings.json
docker compose down --volumes && docker compose build --parallel && docker compose up
in a second terminal window docker compose run data-generation
navigate to software overview
if there are no highlights, login as admin and add some
click on the "Browse all Highlights" button below the highlights carousel
verify that filters work correctly and offer options that correspond to the displayed highlights

Points to be regarded in followup PR:

how to configure the amount of highlights shown in the carousel (e.g. settings.json vs switch in admnin frontend?)
how to specify whether the "Browse all highlights" button is shown on software index page?
as an administrator, does it make sense when adding a new highlight, the position will have the highest number and that it has to be moved manually to position 1?

PR Checklist:

dmijatovic commented 2 months ago

I made limit variable and added notification on the admin page. I set the limit to 5 items in settings.json.

@cmeessen, @jmaassen and @ewan-escience Can you validate please?

sonarcloud[bot] commented 2 months ago

Quality Gate passed for 'rsd-database'

sonarcloud[bot] commented 2 months ago

Failed conditions
16.5% Duplication on New Code (required ≤ 3%)

jmaassen commented 2 months ago

Works well, so go ahead and merge.

Some points for improvement at a later time:

It would indeed be more convenient to always add the new highlights at the top position
On the "all software highlights" page, the default order is "newest first" which implies a chronological order. There is no timestamp of any kind on the highlight cards however? Do we want this?
When adding highlights, the search bar also shows results that are already highlighted. Adding them again gives an error. We should either not show these in the search result, or alternatively, adding them again means moving them to the top spot again?