research-software-directory / RSD-as-a-service

This repo contains the new RSD-as-a-service implementation

https://research.software

23 stars 14 forks source link

Add user.role to dependency and fix typo #1175

Closed dmijatovic closed 5 months ago

dmijatovic commented 5 months ago

Fix typing error in the component name

Changes proposed in this pull request:

Include user?.role in the dependency array of useEffect hook (fix linter warning)
Fix typo in the name of UserAgreementModal component

How to test:

make start to build and generate test data
login with first user, that will be rsd-admin role. Confirm by seeing Adminstration option in user menu
try to add software. As rsd admin you will not see UserAgreementModal
login as different user, not rsd-admin.
try to add software. You should see UserAgreementModal only once to accept user agreement

PR Checklist:

[ ] Increase version numbers in docker-compose.yml
[ ] Link to a GitHub issue
[ ] Update documentation
[ ] Tests

sonarcloud[bot] commented 5 months ago

Quality Gate passed for 'rsd-frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud