feat: admins can set parent organisation

[cmeessen]

Admins can set parent organisation in frontend

Closes #1177

Changes proposed in this pull request:

• adds a feature for administrators to be able to set the parent organisation of an organisation
• visually separates the block with administrator settings under "General settings"

How to test:

• docker compose build --parallel && docker compose up --scale scrapers=0
• docker compose run data-generation
• login as administrator
• open an organisation page and navigate to settings
• copy the organisation id from within the admin panel\
• open another organisation's settings and paste the organisation id into the "Parent organisation ID" field
• verify that the organisation is now a child of the other organisation
• alter the organisation id so that it is invalid => error is shown
• remove the parent organisation id and verify that the organisation is now not a child organisation anymore
• check the corresponding sections in the documentation (http://localhost:3000//documentation/rsd-instance/administration/#edit-organisation and http://localhost:3000/documentation/users/organisation/#what-can-organisation-maintainers-do)

PR Checklist:

• [ ] Increase version numbers in docker-compose.yml
• [x] Link to a GitHub issue
• [x] Update documentation
• [ ] Tests

[dmijatovic]

One general remark. Changing the slug or the parent value will completely break the organisation page (404). This is solved on edit software slug page (see ...software/edit/information/AutosaveSoftwareTextField.tsx, line 55).

Maybe is more suitable to move the complete rsd admin section to rsd admin pages and extend editing the organisation props there? The other location could be parent organisation/add research unit?

I am curious what others think about the location of rsd admin feature(s).

[cmeessen]

One general remark. Changing the slug or the parent value will completely break the organisation page (404). This is solved on edit software slug page (see ...software/edit/information/AutosaveSoftwareTextField.tsx, line 55).

The page is now reloaded using the correct slug.

Maybe is more suitable to move the complete rsd admin section to rsd admin pages and extend editing the organisation props there? The other location could be parent organisation/add research unit?

That could potentially make sense, however as there were already fields that could only be set by admins I found it the most straight forward way to also set the parent here.

[cmeessen]

Ready to merge from my point of view

[jmaassen]

When I set or unset the parent ID and leave the focus of the parentID field I get redirected to an API endpoint?

For example, whet I create two organizations in an empty RSD (using ROR 00rbjv475 and 037aan677):

And then copy the ID of NL eScience and set it as parent ID of NZ eScience:

Then when leaving the ParentID field, the next screen I get is this:

Is that the expected behavior? (I'm on firefox by the way).

[cmeessen]

Apologies, @dmijatovic was right, there was a typo with the url variable. I fixed it and it works now.

[sonarcloud[bot]]

Quality Gate passed for 'rsd-frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
57.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud