1179 ror requests - Githubissues

research-software-directory / RSD-as-a-service

This repo contains the new RSD-as-a-service implementation

https://research.software

23 stars 14 forks source link

1179 ror requests #1180

Closed ewan-escience closed 5 months ago

ewan-escience commented 5 months ago

Remove unnecessary requests to ROR API

Changes proposed in this pull request:

Prevent the Next.js server from making requests to the ROR API when the ROR ID is missing on organisation pages
Fix some typos in the frontend README
Add a section to the frontend README explaining how to intercept HTTP requests on the Next.js server

How to test:

docker compose down --volumes && docker compose build --parallel && docker compose up --scale data-generation=1
Start the frontend dev server with yarn dev
Follow the new instructions on the README
On http://localhost:3000, check out an organisation without a ROR ID, no requests should be made to the ROR API
Compare to an organisation that has a ROR ID

Closes #1179

PR Checklist:

[ ] Increase version numbers in docker-compose.yml
[x] Link to a GitHub issue
[x] Update documentation
[ ] Tests

sonarcloud[bot] commented 5 months ago

Quality Gate passed for 'rsd-frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
13.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud