research-software-directory / RSD-as-a-service

This repo contains the new RSD-as-a-service implementation
https://research.software
23 stars 14 forks source link

1194 mentions overview admins #1197

Closed ewan-escience closed 4 months ago

ewan-escience commented 4 months ago

Add mentions overview for admins

Changes proposed in this pull request:

How to test:

Closes #1194

PR Checklist:

jmaassen commented 4 months ago

Works well, but I do have some comments:

Screenshot 2024-05-14 at 13-26-38 Mentions overview Admin page Research Software Directory

Screenshot 2024-05-14 at 13-27-36 Mentions overview Admin page Research Software Directory

Other points:

Oh, and the pop up fits fine on my screen ;-)

ewan-escience commented 4 months ago

it seems more logical to me to put the "mentions overview" tab directly under "keywords". Also rename to just "mentions" to fit with the other descriptions?

Done

when on the middle of a page of mentions, it becomes hard to figure out which pencil belongs to which entry

Maybe @dmijatovic knows how to do something about this

clicking the entry takes me to the 'target' of the mention (like DOI or URL), instead of showing me the content of the RSD which is more logical to me?

Changing this would also change how this works on software and project pages. Or we'd have to make a copy of the component.

for the pop-up, the "external ID" has no help text? What does it do?

I added a small help text

also, the authors field says "list all authors" as help. I guess its just a single text field, so the choice of format or seperator does not matter? There are no multi author examples in the generated data I think

Separator does indeed not matter, it's a single field in the database.

It's not entirely clear on which fields you can search the mentions?

I don't know how to add this consisely. We don't have this info on other search boxes either.

I cannot search on the UUID. This would be convenient, as the quality check I'm currently using gives me a list of UUIDs of mentions which have issues.

I added this functionality.

dmijatovic commented 4 months ago

"when on the middle of a page of mentions, it becomes hard to figure out which pencil belongs to which entry"

We can add on hover style to visual mark the list item so you know which one you are hovering. I can have a look at this :-)

dmijatovic commented 4 months ago

@ewan-escience @jmaassen I have added hover styling to make more clear which item you are on and changed styles a bit :-).

image

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed for 'rsd-frontend'

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
14.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud