research-software-directory / RSD-as-a-service

This repo contains the new RSD-as-a-service implementation
https://research.software
23 stars 14 forks source link

Increase character limit for mention title #1206

Closed ewan-escience closed 4 months ago

ewan-escience commented 4 months ago

Increase character limit for mention title

Changes proposed in this pull request:

How to test:

Closes #1205

PR Checklist:

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed for 'rsd-database'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed for 'rsd-frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

ewan-escience commented 4 months ago

I updated the limit to be 3000 instead of 1000, because the mention with DOI 10.1103/physrevlett.131.251802 went over that limit. Please test with this DOI as well.

dmijatovic commented 4 months ago

I have 2 remarks we might address it in this PR or in a new one.

ewan-escience commented 4 months ago

The amount of 50.000 chars combined with the form functionality we offer (char count and direct error signaling) breaks at ~ 25.000 chars on my PC.

I think in practice, most entries will have a size well below that. However, I don't know how to solve that for the few exceptional cases. Maybe trade React for something capable. 😉

The author without expected props produces undefined entry. See example 10.1103/physrevd.108.072003. The last author has only name prop. We should improve import to use name when "expected" name props are not delivered.

Nice find! That's an existing bug, I will make an issue out of it.