research-software-directory / RSD-as-a-service

This repo contains the new RSD-as-a-service implementation
https://research.software
23 stars 14 forks source link

1214 community settings #1218

Closed dmijatovic closed 4 months ago

dmijatovic commented 4 months ago

Community module hidden by default

Closes #1214

Changes proposed in this pull request:

How to test:

PR Checklist:

dmijatovic commented 4 months ago

@cmeessen Can you confirm that this approach will work for you? Let me know, if you have questions or suggestions.

jmaassen commented 4 months ago

Few observations:

cmeessen commented 4 months ago

It does work, but when switching off the communities, the font size is rather small given that there are only three elements.

Original header:

image

Header in this branch, but communities disabled:

image

dmijatovic commented 4 months ago

@cmeessen I found smaller fonts looking OK with less items. However, I have extended styles to use larger fonts (as it was previously) when there are less than 4 items in the header. I also made small improvement in feedback modal when used on small screens.

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed for 'rsd-frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
35.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud