research-software-directory / RSD-as-a-service

This repo contains the new RSD-as-a-service implementation
https://research.software
23 stars 14 forks source link

1212 categories for communities #1227

Closed ewan-escience closed 3 months ago

ewan-escience commented 3 months ago

Categories for communities, interface for creating and updating categories

Changes proposed in this pull request:

How to test:

Todo in this PR:

Todo:

Related to #1216

Related to #1212

Related to #1141

Related to #992

Related to #975

PR Checklist:

ewan-escience commented 3 months ago

@fembau can you to do the open point in the PR description?

EDIT: not needed anymore, I removed the function from the database, query the category table directly and recreated the same data structure on the frontend

jmaassen commented 3 months ago

For me the categories connected to a community are not saved? When I add some and reload, they are gone again...

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed for 'rsd-database'

Issues
34 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
7.4% Duplication on New Code

See analysis details on SonarCloud

ewan-escience commented 3 months ago

For me the categories connected to a community are not saved? When I add some and reload, they are gone again...

Good catch, I forgot to attach those categories to the community, so they were saved as global categories instead. It should be fixed now.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed for 'rsd-frontend'

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
1.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud