research-software-directory / RSD-as-a-service

This repo contains the new RSD-as-a-service implementation
https://research.software
27 stars 14 forks source link

1253 communities redirect #1255

Closed ewan-escience closed 4 months ago

ewan-escience commented 4 months ago

Various frontend fixes

Changes proposed in this pull request:

How to test:

Closes #1253

Closes #1254

PR Checklist:

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed for 'rsd-frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
54.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

jmaassen commented 4 months ago

When I switch between communities via the search bar, the logo and description are correctly updated. However I do see that the default ordering seems to get lost?

For example, I start in this community:

Screenshot 2024-07-17 at 15-08-27 Community furthermore Research Software Directory

Then use the search bar to find another and switch to that one:

Screenshot 2024-07-17 at 15-08-43 Community demineralize manservant Research Software Directory

The "order by mentions" is now lost.

ewan-escience commented 4 months ago

Yes, that's another issue I want to pickup in a different branch after this one. It has to do with the URL not having a sort parameter, and the frontend doesn't pick a default sort order then.

Edit: I plan to solve this in #1256.