fix: pages have default ordering, remove ordering from navigation links - Githubissues

research-software-directory / RSD-as-a-service

This repo contains the new RSD-as-a-service implementation

https://research.software

27 stars 14 forks source link

fix: pages have default ordering, remove ordering from navigation links #1258

Closed ewan-escience closed 4 months ago

ewan-escience commented 4 months ago

Default ordering for software overview pages, hide request counts for communities

Changes proposed in this pull request:

Remove the verious ordering query parameters from various links
When no, or an invalid, ordering is in the URL, a default ordering is used
Hide the request counts from the community overview page when not an admin
Users can only see approved software on a community page (and in the database)

How to test:

docker compose down --volumes && docker compose build --parallel && docker compose up --scale data-generation=1
Enable the community module
Using the navigation bar, visit software and projects, notice there is no order query parameter, but the filter modal on the left does show an ordering
Same when visiting a community
Same when visiting an organisation
On the community overview pages, the request counts should only be shown for RSD admins

Closes #1256

PR Checklist:

[ ] Increase version numbers in docker-compose.yml
[x] Link to a GitHub issue
[ ] Update documentation
[ ] Tests

sonarcloud[bot] commented 4 months ago

Quality Gate passed for 'rsd-database'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud[bot] commented 4 months ago

Quality Gate passed for 'rsd-frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
56.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud