Option to disallow package manager harvesting - Githubissues

research-software-directory / RSD-as-a-service

This repo contains the new RSD-as-a-service implementation

https://research.software

27 stars 14 forks source link

Option to disallow package manager harvesting #1264

Closed ewan-escience closed 3 months ago

ewan-escience commented 3 months ago

Option to disallow package manager harvesting

Changes proposed in this pull request:

Admins can disable the harvesting of specific package managers statistics by supplying a reason as to why it is disabled
Page maintainer can see if and why a harvester is disabled on the Background services tab
Add documentation on this

How to test:

docker compose down --volumes && docker compose build --parallel && docker compose up --scale data-generation=0
Sign in as admin
Create a software page, publish it and add some package managers
Disable those package managers
Check that the reason is visible on the Background services tab
Run the harvesters: docker compose exec scrapers java -cp /usr/myjava/scrapers.jar nl.esciencecenter.rsd.scraper.package_manager.MainPackageManager
Check that the *_updated_at fields are still null at http://localhost/api/v1/package_manager
Enable harvesting again by removing the reasons
Run the harvesters again
Check that the applicable *_updated_at fields are now set
Check out the new documentation under http://localhost/documentation/rsd-instance/administration/#software

Closes #1117

PR Checklist:

[ ] Increase version numbers in docker-compose.yml
[x] Link to a GitHub issue
[x] Update documentation
[ ] Tests

sonarcloud[bot] commented 3 months ago

Quality Gate passed for 'rsd-database'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud[bot] commented 3 months ago

Quality Gate passed for 'scrapers'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud[bot] commented 3 months ago

Quality Gate passed for 'rsd-frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
35.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

cmeessen commented 3 months ago

Works as described :+1: The two fields in the admin view are a bit unfortunate. Maybe using a modal for the messages would improve that?

ewan-escience commented 3 months ago

Let's discuss with @dmijatovic when he is back.