Don't show duplicate maintainers - Githubissues

research-software-directory / RSD-as-a-service

This repo contains the new RSD-as-a-service implementation

https://research.software

27 stars 14 forks source link

Don't show duplicate maintainers #1269

Closed ewan-escience closed 3 months ago

ewan-escience commented 3 months ago

Don't show duplicate maintainers

Changes proposed in this pull request:

When someone is both a primary and regular maintainer of an organisation or a community, don't show them in the list of maintainers twice, by fixing the respective database functions

How to test:

docker compose down --volumes && docker compose build --parallel && docker compose up --scale data-generation=1
Sign in as admin
Create some maintainer invitations for an organisation, accept them on different accounts
Assign a regular maintaine rto also be a primary maintainer
The primary maintainer should not be duplicated in the maintainers list
The primary maintainer should be shown first
Do the same for communities

Closes #1230

PR Checklist:

[ ] Increase version numbers in docker-compose.yml
[x] Link to a GitHub issue
[ ] Update documentation
[ ] Tests

sonarcloud[bot] commented 3 months ago

Quality Gate passed for 'rsd-database'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud