Deduplicate and test some authentication code - Githubissues

research-software-directory / RSD-as-a-service

This repo contains the new RSD-as-a-service implementation

https://research.software

27 stars 14 forks source link

Deduplicate and test some authentication code #1272

Closed ewan-escience closed 3 months ago

ewan-escience commented 3 months ago

Deduplicate and test some authentication code

Changes proposed in this pull request:

Deduplicate and test some of the code in the authentication module

How to test:

docker compose down --volumes && docker compose build --parallel && docker compose up --scale data-generation=1
Sign in through various methods, including SURFconect, Azure and ORCID (put your ORCID on the allowlist first as admin)

PR Checklist:

[ ] Increase version numbers in docker-compose.yml
[ ] Link to a GitHub issue
[ ] Update documentation
[x] Tests

sonarcloud[bot] commented 3 months ago

Quality Gate failed for 'authentication'

Failed conditions
11.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud