dmijatovic commented 3 months ago

Rsd admin can edit package manager item

Closes #1277

Changes proposed in this pull request:

Rsd admin can edit package manager item. It can:
- disable service by adding a comment into designated input field. The input is enabled only for the services that are "supported". The info about "supported services" is kept locally (in an data object) and need to be manually updated.
- change "detected platform" using a drop-down options. The list of supported providers is kept locally (in same data object) and need to be manually updated.
When updating package manager entry only platform and the reasons for disabling are updated

How to test:

make start to build app and create test data
login as rsd_admin, first user should become rsd_admin automatically if you have correct .env settings
open first software item and navigate to package managers section
confirm you can edit existing item
confirm you can provide reason to stop scraping
confirm that disabling is visible on the PackMan page
confirm that disabling is visible on the background services page
confirm you can create new item
login as regular rsd user
edit or create software item
navigate to package manager section
confirm you cannot edit package manager item
confirm you can delete and add new items

Add package manager (not changed)

Admin package manager modal (to disable service or change platform)

Example disabled service on PM page

Example disabled service on services page

PR Checklist:

[ ] Increase version numbers in docker-compose.yml
[ ] Link to a GitHub issue
[ ] Update documentation
[ ] Tests

jmaassen commented 3 months ago

Setting the message works well, and the difference between admin and regular user is as expected.

However, when I set the message as an admin, I don't see any visual feedback on this as a user in the package manager section (only in the 'background services section'). An improvement would be to add some icon or message indicating a error, that links to the background services section?

dmijatovic commented 3 months ago

@jmaassen & @ewan-escience Thanks for the feedback. I have improved working of the modal and the messaging (see printscreens in the PR):

When you edit item only the services that are defined for the provider can be disabled by providing text. Note that for some platforms both inputs will be disabled because we do not have scraper services.
RSD admin can change detected platform. Note the modal for the users remains unchanged as it was...only for rsd admins, the edit button is shown and the modal has different options.

Note! I have rebased to latest changes from main. so you will need to load remove old branch and load this PR branch again.

jmaassen commented 3 months ago

Works well.

Small comment:

Screenshot 2024-08-23 at 09-38-39 Edit software Research Software Directory