Closed dmijatovic closed 2 months ago
@ewan-escience Thanks. I'll fix typescript version, it seem to be changed during install of knip. Concerning the exports "feature", I tried it but do not see added value at the moment. The exported functions are used in the file itself by some other functions. The reason that these functions are exported is to indicate that these can be used from other location, so the functions are not necessary the private functions.
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code
Replace unimported with knip
Closes #1273
Changes proposed in this pull request:
How to test:
npm install
to install all dependencies. You might also remove old node_modules folder usingrm -rf node_modules
before runningnpm install
npm run knip:files
to check for unimported/unused filesnpm run knip:types
to check for unused exported type definitionsnpm test
to run unit tests locally. All test should pass.npm run build
to build frontend. The build should be successful.make start
to build app and create test data. The app should work without problems.PR Checklist:
docker-compose.yml