research-software-directory / RSD-as-a-service

This repo contains the new RSD-as-a-service implementation
https://research.software
27 stars 14 forks source link

Replace unimported with knip #1285

Closed dmijatovic closed 2 months ago

dmijatovic commented 3 months ago

Replace unimported with knip

Closes #1273

Changes proposed in this pull request:

How to test:

PR Checklist:

dmijatovic commented 2 months ago

@ewan-escience Thanks. I'll fix typescript version, it seem to be changed during install of knip. Concerning the exports "feature", I tried it but do not see added value at the moment. The exported functions are used in the file itself by some other functions. The reason that these functions are exported is to indicate that these can be used from other location, so the functions are not necessary the private functions.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed for 'rsd-frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud