dmijatovic commented 2 months ago

Edit contributor and team member

Closes #450 Closes #1152

Changes proposed in this pull request:

edit contributor avatar, roles and affiliation using aggregated values from other RSD entries.
edit team member avatar, roles and affiliation using aggregated values from other RSD entries.
Avatar and affiliation values are aggregated based on contributor/team member ORCID.
use of "person" shared components for "edit" modal and search/find option
moved methods to "hook" files
FIX: removed fuzzy search "indicator" from ORCID search url (because it does not produce expected behaviour).
FIX: improve deduplication at import of contributors, use last_name+first name instead of only last_name.
rsd admin can update rsd contributor avatars. The avatars are aggregated on "display_name" (first name + last name) or ORCID.

How to test:

make start to build and generate test data
login as rsd admin
navigate to edit software page, contributors section.
test all options: create, find, edit and delete contributor. You should be able to select avatar images, roles and affiliation based on the data already present in RSD
test contributors with ORCID and without ORCID
navigate to edit project, team members section
test all options: create, find, edit and delete contributor. You should be able to select avatar images, roles and affiliation based on the data already present in RSD
test team members with ORCID and without ORCID
test rsd admin edit avatars section:
- first add yourself to number of software and project items and upload different images
- then navigate to rsd admin, rsd contributors page
- search for yourself by first or last name. You should see a list of your entries. In the avatar column you will see avatar and the count of options. If there is a more than 1 avatar option you will be able to click on avatar and change it.

Contributor modal (example)

Team member modal (example)

Rsd admin - contributors

PR Checklist:

[ ] Increase version numbers in docker-compose.yml
[x] Link to a GitHub issue
[ ] Update documentation
[x] Tests

jmaassen commented 2 months ago

I seem to have found an unrelated bug?

When adding a team member to a project, I get the following options:

Screenshot_2024-09-13_09-24-19

However, when I keep typing, this happens:

Screenshot_2024-09-13_09-24-34

I would expect the "Boyd Edwards" from ORCID to remain at the top, since "Boyd E" is an even better match than just "Boyd"?

jmaassen commented 2 months ago

Another comment (not sure if this is expected behavior):

When testing, I added my own name + orcid as a contributor and team member to software and projects, and added several mugshots. Some of them randomly seemed to disappear when switching between different projects/software.

It took me a while to figure out that this is because the unused foto's are removed as soon as you switch to a different context. This may also confuse our users?

dmijatovic commented 2 months ago

@jmaassen & @ewan-escience I made changes requested by Jason:

uploaded image is not added collection before it is saved. This should reduce confusion why image "disappears"
removed "fuzzy" search parameter from ORCID search because it does not produce "expected" outcomes.

Can you validate again? Thanks!

dmijatovic commented 2 months ago

@jmaassen en @ewan-escience I added avatar update for rsd admin. Can you test all features again please?

jmaassen commented 2 months ago

I think there is still a small bug in de admin part?

I have a contributor A with orcid and multiple avatars.
I copy that orcid to contributor B with a different name and without orcid or avatar.
The avatar list in the admin interface for contributor B does not update. It remains empty also after a reload.
If I go to the software pages mentioning contributor B and click on edit contributor, it does show me all the avatars.

dmijatovic commented 2 months ago

@jmaassen Thanks for the remark. I extended aggregation in the rsd admin section to include ORCID too. Let me know if this approach is OK.