research-software-directory / RSD-as-a-service

This repo contains the new RSD-as-a-service implementation

https://research.software

27 stars 14 forks source link

fix: mention form validation #1305

Closed dmijatovic closed 1 month ago

dmijatovic commented 1 month ago

Fix mention form validation when changing type

Closes #1304

Changes proposed in this pull request:

The modals are conditionally rendered in order to properly load initial form data for editing
When changing mention type from highlight to other type the rules are improved (required is set to false)
Manually remove highlight specific error from the error object after type is changed

How to test:

make start to build and generate test data
login as rsd admin and try to manually create or edit mentions
When using highlight mention type you will need to provide image_url before save button is enabled (form is valid)
Try changing the mention type from highlight to other types. You should be able to save mention without image_url (save button should be enabled)

Edit mention modal

PR Checklist:

[ ] Increase version numbers in docker-compose.yml
[ ] Link to a GitHub issue
[ ] Update documentation
[ ] Tests

sonarcloud[bot] commented 1 month ago

Quality Gate passed for 'rsd-frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
68.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud