research-software-directory / RSD-as-a-service

This repo contains the new RSD-as-a-service implementation

https://research.software

27 stars 14 forks source link

fix: add slug for software, projects and news #1340

Closed dmijatovic closed 1 week ago

dmijatovic commented 2 weeks ago

User cannot create software or project using "add" slug

Closes #1338 Related to #525

Changes proposed in this pull request:

Move add software, project and news to add route
The slug validation feedback to user is improved. From the moment the user start typing/changing slug until the end of the validation we show "loader" in the slug input indicating "pending" validation process. At the same time the save button is disabled.
UNRELATED: Adapted width of custom pages to 1024px for easier reading.

How to test:

make start to build and create test data
login to RSD
create software, try to use "add" as slug. Try using other slugs. Test also used slugs that should return error.
create project, try to use "add" slug. Try using other slugs. Test also used slugs that should return error.
create news, try to use "add" slug. Try using other slugs. Test also used slugs that should return error.
Examine custom pages: About, Terms of service, Cookies etc.

Example cookies page layout

PR Checklist:

[ ] Increase version numbers in docker-compose.yml
[ ] Link to a GitHub issue
[ ] Update documentation
[ ] Tests

jmaassen commented 1 week ago

Works well, but I seem to have found one small bug?

Sometimes when I add software with a duplicate slug, the warning doesn't appear and the loader keeps on turning. No error is shown:

Screenshot_2024-11-11_11-15-41

As soon as I replaced the name with an unused one, then followed by the used one, the error is shown correctly.

I can reproduce this with both software and projects:

click on add software
create software called "add"
click on add project
create project called "add"
click on add software
create software called "add" (now turns forever)
replace "add" by test, but don't save
replace "test" by "add" (error is now shown)
click on add project
create project called "add" (now turns forever)
replace "add" by test, but don't save
replace "test" by "add" (error is now shown)
repeat!

dmijatovic commented 1 week ago

@jmaassen Well spotted! I have fixed the error. Can you test again, please?

sonarcloud[bot] commented 1 week ago

Quality Gate passed for 'rsd-frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
52.9% Coverage on New Code
1.7% Duplication on New Code

See analysis details on SonarQube Cloud

dmijatovic commented 1 week ago

@ewan-escience Great! I fixed your remark. Can you validate, please?