Fix some SonarCloud issues - Githubissues

research-software-directory / RSD-as-a-service

This repo contains the new RSD-as-a-service implementation

https://research.software

27 stars 14 forks source link

Fix some SonarCloud issues #1345

Closed ewan-escience closed 1 week ago

ewan-escience commented 1 week ago

Fix some SonarCloud issues

Changes proposed in this pull request

Fix some low-effort SonarCloud issues
Add a logger to the authentication module

How to test

docker compose down --volumes && docker compose build --parallel && docker compose up --scale data-generation=1
The build should succeed without errors
Sign in as admin and user, through various providers, this should still work

PR Checklist:

[ ] Increase version numbers in docker-compose.yml
[x] Link to a GitHub issue
[ ] Update documentation
[ ] Tests

sonarcloud[bot] commented 1 week ago

Quality Gate passed for 'authentication'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
3.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarcloud[bot] commented 1 week ago

Quality Gate passed for 'scrapers'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
25.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud