search

researchapps / sherlock

repository for collaborating with sherlock users to create containers
MIT License
5 stars 1 forks source link

Dockerfile for pytorch in python2 won't build #3

Closed dbdean closed 6 years ago

dbdean commented 6 years ago

Hi, thanks for the help in getting pytorch running in python 2.7 using your Dockerfile at https://github.com/researchapps/sherlock/blob/master/pytorch-dev/Dockerfile.py2. I did have to make some changes to get it to work however. This resolves Issue #2.

vsoch commented 6 years ago

Fantastic! It's after midnight where I am, so I will test this tomorrow and we can get it merged and then pushed to Docker Hub so others can easily pull it. I'm really excited and grateful that you made the contribution, and looking forward to testing it out.

vsoch commented 6 years ago

okey just did some very basic testing - and I'll let our users know to do further testing. The changes look good and again, many thanks for doing them!

vsoch commented 6 years ago

In a perfect world we would have CI and a builder set up for this, but I'm good for now with a manual push to Docker Hub and the build recipe maintained here. Merging!