researchart / fse18

artifacts track, FSE'18: https://2018.fseconference.org/home
2 stars 2 forks source link

Si-datalog #15

Closed obaysal closed 6 years ago

obaysal commented 6 years ago

https://github.com/researchart/fse18/tree/master/submissions/datalog

ReviewerArtFSE18 commented 6 years ago

The authors apply for the Replicated badge, but unfortunately the artifact does not meet the requirements.

According to the ACM definition, Replicated badges must fulfill the following (https://2018.fseconference.org/track/fse-2018-Artifacts): "Available + main results of the paper have been obtained in a subsequent study by a person or team other than the authors, using, in part, artifacts provided by the author."

In addition, for granting the "Resuable" badge: "Functional + very carefully documented and well-structured to the extent that reuse and repurposing is facilitated. In particular, norms and standards of the research community for artifacts of this type are strictly adhered to."

The accompanied documentation is limited . For example:

I could run the tool, but it was not straightforward to install and run for the issues mentioned above. I created a Virtual Machine with Linux to be able to run the tool.

Consequently, the artifact meets the requirements for the Functional badge.

XujieSi commented 6 years ago

We thank the reviewers for their helpful feedback, which we will incorporate in the revision of our artifact.

It seems that we misunderstood certain requirements of Replicated badge. For example, we assumed that the artifact evaluation could serve as "an external study which replicates the artifact results". As for "Available", we indeed provided a publicly accessible link, which is a public github repo: https://github.com/XujieSi/fse18-artifact-183/releases, during the submission. We are willing to create a DOI for our artifact, if that is the only acceptable standard. Due to confusion of requirements of various badges, we are also open to other badges that are most appropriate for our artifact in the view of reviewers.

We agree that we should make it explicit that the submitted artifact can be easily set up on Linux platform. However, it does NOT require installation of Z3 or have to be executed inside z3_env/z3 folder. Because a pre-built Z3 library on Linux platform is already included and the provided script "setenv" should set up environments properly. A single make command after setting environments (i.e. run . setenv) should suffice (as described in step-2).

For platforms other than Linux, one does need to compile the Z3 library and adjust the library path of Z3 in Makefile accordingly.

timm commented 6 years ago

Is there a confusion in badge requirements--- we stated them as clear as we could in our CFP. can you point to any confusing text that we need to fix?

image

davisjam commented 6 years ago

Perhaps we can centralize discussion of badges here.

XujieSi commented 6 years ago

@timm Thanks for clarifying!
Specifically, I am confused by the requirement of Available badge: "A DOI or link", which sounds like either DOI or some publicly accessible URL provided by cloud vendors (e.g. Dropbox, Google Drive, GitHub repo, etc.) should be fine. But the actual expectation seems to be only DOI, as pointed out by our reviewer.

Similarly, the requirement of Replicated badge: "by a person or team other than the authors" is little confusing to me. Could the anonymous reviewers be the "person or team other than the authors"? Or we (the authors) need to contact some person or team and show evidence that the artifacts are reproducible before the artifact evaluation?

davisjam commented 6 years ago

@XujieSi A DOI is an archive-quality name for a thing. So you can get a DOI by putting your artifact in some archival service -- e.g. Zenodo, which is popular in the SE community. That's what I did. A GitHub repository is not archive-quality, since you can forcibly push to it and rewrite the history (perils of mining git). It looks like GitHub actually integrates with Zenodo which might be easier to use than using Zenodo independently.

XujieSi commented 6 years ago

@davisjam Thanks for explaining the DOI, which I did not know much about. I will prepare the DOI for our artifact. Then, perhaps we should just say "A DOI to" instead of "A DOI or link to" in the description of Available badge, because "link" could mean a lot of things.

davisjam commented 6 years ago

@XujieSi See also this recent remark from @timm.

XujieSi commented 6 years ago

@davisjam Thanks a lot!! The integration of Zenodo and GitHub is super helpful. I just made my first ever DOI

I guess it might be a bit late to submit DOI, but anyway this DOI is exactly for our original artifact submission.

anonymous357 commented 6 years ago

Sorry for my late review.

At least for me, it is difficult to reproduce the main experiment. I had tried to perform "Examine experimental logs" in the README.md file, however, I got an error message as follows: Traceback (most recent call last): File "scripts/parse_log.py", line 6, in with open(sys.argv[1]) as f: IOError: [Errno 21] Is a directory: 'mklog/' Note that my environment is Fedora release 28 with python 2.7.15 version.

The other steps were successfully done, and it was easy for me. So I believe that this paper meets the requirement of "Functional" badge.

In addition, the authors have made their tool publicly available on Github repository with doi. Thus, I believe the artifact can get their "Available" badge.