researchgate / gemini-react

Plugin, which simplifies writing gemini tests for react components
https://github.com/researchgate/gemini-react
MIT License
22 stars 4 forks source link

feat(setup): provide global react for jsx test scope #21

Closed tx44 closed 8 years ago

tx44 commented 8 years ago

Autorequire React for JSX in each test scope.

SevInf commented 8 years ago

I don't think it should be the thing we do by default. Not every setup needs it and the ones who do, can already achieve this by using js gemini config:

global.React = require('react');

module.exports = {
    rootUrl: 'http://www.example.org',
   ....
}
SevInf commented 8 years ago

On the same note, I'm not sure anymore, if doing webpack stuff in plugin was that great of idea. Making Node.js consume server-side code requires quite a bunch of hacky workarounds.

So, maybe in future versions we should just require node.js bundle to be prebuilt (with webpack --target node).

tx44 commented 8 years ago

Ok