Proposal to add `commitOptions` to git config -- Update GitAdapter.groovy

researchgate / gradle-release

gradle-release is a plugin for providing a Maven-like release process for projects using Gradle

MIT License

859 stars 223 forks source link

Proposal to add `commitOptions` to git config -- Update GitAdapter.groovy #367

Closed loosebazooka closed 2 years ago

loosebazooka commented 2 years ago

Proposal for adding git commit options.

This means a user can do something like ["-s"] to satisfy DCO bots: https://github.com/apps/dco

loosebazooka commented 2 years ago

Thought about an explicit config for signing like we have for tags but I personally prefer a generic option.

To me there's a very strong difference between "signing" and "signing-off" here. I'm mostly concerned with -s "sign-off" to satisfy the DCO bot, but I think the word "signing" would more align with -S.

I'll keep this generic for now.