search

researchgate / gradle-release

gradle-release is a plugin for providing a Maven-like release process for projects using Gradle
MIT License
859 stars 223 forks source link

Gradle 9.0: The StartParameter.settingsFile property has been deprecated. #379

Open IRus opened 1 year ago

IRus commented 1 year ago

The StartParameter.settingsFile property has been deprecated.
This is scheduled to be removed in Gradle 9.0.
Please use 'projectDir' to specify the directory of the default project instead.
Documentation 1 usage Plugin:net.researchgate.release

at org.gradle.StartParameter.logBuildOrSettingsFileDeprecation(StartParameter.java:504) 
    •••
at net.researchgate.release.ReleasePlugin$_apply_closure5.doCall(ReleasePlugin.groovy:107)  
    •••
at net.researchgate.release.ReleasePlugin.apply(ReleasePlugin.groovy:100)   
at net.researchgate.release.ReleasePlugin.apply(ReleasePlugin.groovy)   
    •••
Vampire commented 1 year ago

Would probably also be fixed by fixing #304

patton73 commented 7 months ago

Any news in fixing this? Thanks.

andersb commented 6 months ago

Just updated to Gradle 8.x and got the same warning. It still works for now but at some point this might hold back updating Gradle. Great plugin otherwise 👍

pgehl commented 5 months ago

Gradle 9.0 is coming fast. And no code commit listed in the last 2 years. Is this project still alive ?

patton73 commented 5 months ago

Honestly i cannot understand why people start projects and the suddenly abandon them. I hope this project is not dead. But no commits in 2 years is a really bad signal.

windmueller commented 5 months ago

Honestly i cannot understand why people start projects and the suddenly abandon them.

You can't seriously imagine that personal circumstances could change in such a way that one can no longer find the time for a project that one would like to take?

But perhaps the author no longer uses Gradle so there could be a huge drop regarding motivation.

However, this is all speculation and has nothing to do with the problem at hand. Perhaps it is time for an "official" fork.

pgehl commented 5 months ago

My apologies to the author . My question was not ment in an offensive way. I'm honestly grateful for this plugin and all the years I used it free of charge. I asked only if the project was still alive to be able to plan a transition for the tens of projects that use it. Again, thanks the author(s) for all those years.

patton73 commented 5 months ago

You can't seriously imagine that personal circumstances could change in such a way that one can no longer find the time for a project that one would like to take?

Well sure i can imagine because real life could always be very complicated. But when this happens then you can always try to find someone else who can continue the work. The community is usually big and people are awesome in helping. Asking for help does not cost too much.

patton73 commented 5 months ago

I asked only if the project was still alive to be able to plan a transition for the tens of projects that use it.

Ehm excuse me. Plan a transition to what exactly? Is there a similar plugin? Thanks for any information you can provide.

pgehl commented 5 months ago

Is there a similar plugin?

I don't know, answering that question will be one of the early parts of the transition plan.

Doc94 commented 3 months ago

maybe im confuse but this cannot help or is totally different task? https://docs.gradle.org/current/userguide/publishing_maven.html

Vampire commented 3 months ago

Totally different, yes. :-)

IRus commented 3 months ago

If the fix for this particular issue is just removing one line?

https://github.com/researchgate/gradle-release/blob/main/src/main/groovy/net/researchgate/release/ReleasePlugin.groovy#L107

Or this change would break some older Gradle versions?

patton73 commented 3 months ago

Dunno really if it will break older version but basically a new plugin version can be compatible with latest gradle's versions. and not every one. At least it should be. And are we sure that the plugins itself does not uses that property inside instead of projectDir property?

Vampire commented 3 months ago

If the fix for this particular issue is just removing one line?

There are other problems, and as I said above, the best would be to solve #304 which would also fix this one alongside.

IRus commented 3 months ago

@Vampire yes, I agree, but it appears that this is a minor fix that can be done before #304

@Hillkorn any chance giving commit rights to @Vampire? I can help with testing. Gradle seems not pushing 9.0 soon, there is 8.8-8.10 in queue, but composite builds requested by the community, and we could work on fixing this, as well as merging PR queue.