researchgraph / Crosswalks

Crosswalk code from {system X} to the ReseachGraph schema
MIT License
1 stars 1 forks source link

figshare: remove "//" from keys #35

Closed aaryani closed 7 years ago

aaryani commented 7 years ago

Some records have "//" in their author key. I noticed these records have no public profile.

For example, all of the followings are broken URLs: https://figshare.com/authors//1228602-vcard https://figshare.com/authors/1228602-vcard https://figshare.com/authors/1228602

      <researcher>
         <key>researchgraph.org/figshare/authors//1228602</key>
         <source>figshare.com</source>
         <local_id>/1228602-vcard</local_id>
         <url>https://figshare.com/authors//1228602-vcard</url>
         <full_name>Glauco Roberto Munsberg</full_name>
         <first_name>Glauco</first_name>
         <last_name>Roberto Munsberg</last_name>
      </researcher>

So I suggest

A) we remove "URL" element for any researcher that "//" in vivo:Authorship[1]//vcard:Individual/@rdf:about

B) lets use vivo:Authorship[1]//vcard:Individual/@rdf:about always as local_id for researcher even when there is an ORCID. But remove "/" or "//" from the begining

C) Since with inclusion of "vcard" we know it is an author not a publication, please remove "author" from the key.

So for https://figshare.com/authors/David_Groenewegen/1176435-vcard local_id = 1176435-vcard key = researchgraph.org/figshare/1176435-vcard

aaryani commented 7 years ago

More example available at https://github.com/researchgraph/Crosswalks/blob/master/figshare.com/sampleWithOrcidOutputRDF.xml