Please check if your PR fulfills the following requirements:
[ ] Affected Tests have been added/altered (for bug fixes / features)
[ ] Docs have been reviewed and added/updated if needed (for bug fixes / features)
[x] Build was run locally and mvn install succeeds
Pull request type
Please check the type of change your PR introduces:
[x] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):
What is the current behavior?
when creating an atom via the owner webapp, the atom would be associated with the user only upon receipt of the success response. That sometimes led to atoms being created but the owner webapp would not associate them with the user (if, for some reason, the response was lost, e.g. bc the webapp went down)
What is the new behavior?
optimistically associate the atom with the user when sending the create message to the node, remove it when it fails.
The webapp can handle non-existing atoms being associated with the user, so this new behaviour is probably more fail-safe
Does this introduce a breaking change?
[ ] Yes
[x] No
Other information
Also changed the fake-names file (remove some adjectives, sorted and removed duplicates)
Pull request checklist
Please check if your PR fulfills the following requirements:
mvn installsucceedsPull request type
Please check the type of change your PR introduces:
What is the current behavior?
when creating an atom via the owner webapp, the atom would be associated with the user only upon receipt of the success response. That sometimes led to atoms being created but the owner webapp would not associate them with the user (if, for some reason, the response was lost, e.g. bc the webapp went down)
What is the new behavior?
optimistically associate the atom with the user when sending the create message to the node, remove it when it fails. The webapp can handle non-existing atoms being associated with the user, so this new behaviour is probably more fail-safe
Does this introduce a breaking change?
Other information
Also changed the fake-names file (remove some adjectives, sorted and removed duplicates)