Fix msgsorting - Githubissues

researchstudio-sat / webofneeds

Finding people to cooperate with. Protocol, not platform. Decentralized. Linked Data. Open Source.

http://researchstudio-sat.github.io/webofneeds/

Apache License 2.0

63 stars 20 forks source link

Fix msgsorting #3328

Closed quasarchimaere closed 4 years ago

quasarchimaere commented 4 years ago

Pull request checklist

Please check if your PR fulfills the following requirements:

[ ] Affected Tests have been added/altered (for bug fixes / features)
[ ] Docs have been reviewed and added/updated if needed (for bug fixes / features)
[X] Build was run locally and mvn install succeeds

Pull request type

Please check the type of change your PR introduces:

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[X] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Currently message Sorting is "off" if messages are reloaded and put agreement messages in the state

What is the new behavior?

message sorting is correct now
adds new helper functions to reduce code duplication (and less string constants)

Does this introduce a breaking change?

[ ] Yes
[X] No