Fixes Connect From Atom (possibly in creation) - Githubissues

researchstudio-sat / webofneeds

Finding people to cooperate with. Protocol, not platform. Decentralized. Linked Data. Open Source.

http://researchstudio-sat.github.io/webofneeds/

Apache License 2.0

63 stars 20 forks source link

Fixes Connect From Atom (possibly in creation) #3345

Closed quasarchimaere closed 3 years ago

quasarchimaere commented 3 years ago

Pull request checklist

Please check if your PR fulfills the following requirements:

[ ] Affected Tests have been added/altered (for bug fixes / features)
[ ] Docs have been reviewed and added/updated if needed (for bug fixes / features)
[X] Build was run locally and mvn install succeeds

Pull request type

Please check the type of change your PR introduces:

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Currently it could happen that a connect message is sent before the from atom exists, resulting in failed connect requests

What is the new behavior?

We refactored the serverSideConnectionAction to support serverSideConnects for recipient atoms that are not owned

Refactor request payload (remove SocketToSocket pojo array) and create a new Payload to support serverside connects to non owned atoms

Does this introduce a breaking change?

[ ] Yes
[X] No

Other information