Please check if your PR fulfills the following requirements:
[ ] Affected Tests have been added/altered (for bug fixes / features)
[ ] Docs have been reviewed and added/updated if needed (for bug fixes / features)
[X] Build was run locally and mvn install succeeds
Pull request type
Please check the type of change your PR introduces:
[X] Bugfix
[X] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):
What is the current behavior?
Currently every Atom is created as a Public Atom, everyone can see it, everyone can connect to it (in addition to the acl defined by the sockets)
Fixes #3367 wsod after connect is prevented
Fixes #3372 jwttokens that are undefined are not breaking the parser anymore
What is the new behavior?
On Create or Edit: Atoms can be public or private now (private: only connected atoms can read the atomContent, everybody can Connect(see #3375 for explanation) any available socket acl will STILL be added to the atom) public atoms work as is
Refactor Plans UseCases to Events
Refactor ACL definitions in detail-definitions.js to use uncompacted vocab
Remove all unnecessary ACLs that are already added through the socket-acls
Pull request checklist
Please check if your PR fulfills the following requirements:
mvn installsucceedsPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Currently every Atom is created as a Public Atom, everyone can see it, everyone can connect to it (in addition to the acl defined by the sockets)
What is the new behavior?
detail-definitions.jsto use uncompacted vocabDoes this introduce a breaking change?
Other information