Please check if your PR fulfills the following requirements:
[ ] Affected Tests have been added/altered (for bug fixes / features)
[x] Docs have been reviewed and added/updated if needed (for bug fixes / features)
[x] Build was run locally and mvn install succeeds
Pull request type
Please check the type of change your PR introduces:
[x] Bugfix
[ ] Feature
[x] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):
What is the current behavior?
The matcher-service removes an atom from the rematching index only if it gets a 410 response. Attempts that fail with other errors are not registered as rematch attempts and are therefore checked for rematching at the next rematch tick (every 60s). This leads to constantly rematching atoms with 401 or 403 responses, flooding the node with requests.
What is the new behavior?
The matcher-service removes an atom from the rematching index if it gets a 410 response and registers a rematch attempt for any other error response (4xx or 5xx), thus the usual back-off strategy is followed. This allows for dealing with temporary unavailability or changing access rights for the matcher.
Pull request checklist
Please check if your PR fulfills the following requirements:
mvn installsucceedsPull request type
Please check the type of change your PR introduces:
What is the current behavior?
The matcher-service removes an atom from the rematching index only if it gets a 410 response. Attempts that fail with other errors are not registered as rematch attempts and are therefore checked for rematching at the next rematch tick (every 60s). This leads to constantly rematching atoms with 401 or 403 responses, flooding the node with requests.
What is the new behavior?
The matcher-service removes an atom from the rematching index if it gets a 410 response and registers a rematch attempt for any other error response (4xx or 5xx), thus the usual back-off strategy is followed. This allows for dealing with temporary unavailability or changing access rights for the matcher.
Does this introduce a breaking change?