search

resend / react-email

💌 Build and send emails using React
https://react.email
MIT License
12.67k stars 583 forks source link

Move @swc/core to dev dependencies of react-email #1385

Closed skelouse closed 2 months ago

skelouse commented 2 months ago

Describe the Bug

Added in this commit I'm not sure why this is added to dependencies and not dev dependencies.

I also found that running pnpm run build here with the package removed requests you to install it with -D

gabrielmfern commented 2 months ago

As mentioned on another few discussions, we do build the preview app before publishing it. At least not yet. It just isn't that trivial as it may seem with the way we are doing things. So once you run email dev Next.js will actually compile the preview app. This is why, if we include it as a dev dependency, it might not be included into the user's installation which will break the email dev command.

Will be converting this into a discussion.