search

resend / react-email

💌 Build and send emails using React
https://react.email
MIT License
12.67k stars 583 forks source link

fix(root): Wrong turborepo default configuration for packages #1469

Closed gabrielmfern closed 2 weeks ago

gabrielmfern commented 2 weeks ago

After #1457 we right away started noticing some issues happening with our preview demo deploy to Vercel because it failed after being merged, but not before being merged, without any extra changes as well.

The problem had to do with caching and what was being cached and used across turborepo sessions, specifically that our default build configuration was:

"build": {
  "dependsOn": ["^build"],
  "outputs": [".next/**", ".next/cache/**"]
},

Meaning that it would try caching all the packages, like it does for Next.js. This was very problematic because the output directories for the majority of the packages we have is located on ./out not in ./next, so this PR fixes exactly this.

You can verify this was indeed the issue by the fact that the deployments succeeded for all the activity since I made the commit changing this configuration.

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-email ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 8:03pm
react-email-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 8:03pm