reservoirprotocol / marketplace-v1

An open source NFT marketplace built on Reservoir.
https://www.reservoir.market
MIT License
173 stars 254 forks source link

fix the media size for HTML (iframe) previews #555

Closed pandurand closed 1 year ago

pandurand commented 1 year ago

Context

Follow up to #548 / #549

The media size for <iframe> is set to 533x533 with a w-full class. This results in the iframe to grow disproportionally when the window size changes. Namely, the width may grow while the height may not.

Proposed fix:

Visual comparison

Before After
Screen Shot 2022-10-19 at 8 13 00 PM Screen Shot 2022-10-19 at 8 16 13 PM

Update

While at it, I propose to fix video media so that they can autoplay in a loop by adding a few attributes to the Video HTML tag:

vercel[bot] commented 1 year ago

@pandurand is attempting to deploy a commit to the Uneven Labs Team on Vercel.

A member of the Team first needs to authorize it.

pedromcunha commented 1 year ago

Made a mistake while merging and merged dev into your branch, sorry about that. I thought it would do the opposite but had a conflict that resulted in this. I just pulled your changes out and made a brand new branch + PR:

559

Let me know if I missed anything. We're testing and will merge this shortly if everything looks good. Thanks for the contribution.

pandurand commented 1 year ago

All good @pedromcunha — I double checked #559 and LGTM.