reservoirprotocol / marketplace-v1

An open source NFT marketplace built on Reservoir.
https://www.reservoir.market
MIT License
173 stars 254 forks source link

Fix all user NFTs showing before mutate method is called #574

Open Andriy1221 opened 1 year ago

Andriy1221 commented 1 year ago

Suggested fix for the following issue: #573 Close: #573

vercel[bot] commented 1 year ago

Someone is attempting to deploy a commit to the Uneven Labs Team on Vercel.

A member of the Team first needs to authorize it.

pedromcunha commented 1 year ago

Yeah this seems to be happening because of the prerendering. I'll add this to our list to fix. I would prefer to maintain the prerendering, this PR actually ignores the prerendered page. I'll add this to our list to investigate and fix. You can have a crack at fixing this yourselves. I would start by looking at where the prerendering logic is happening: https://github.com/reservoirprotocol/marketplace/blob/main/pages/address/%5Baddress%5D.tsx#L219 It could be that the filtering there is just not applying the right filters for that specific environment variable configuration.

jakeywan commented 1 year ago

Just fixed this one for my marketplace, there's just a missing check for COLLECTION in the logic in the file referenced above: https://github.com/reservoirprotocol/marketplace/blob/main/pages/address/%5Baddress%5D.tsx#L219. I'll submit a PR.

Screen Shot 2022-12-02 at 1 48 14 PM