reservoirprotocol / marketplace-v1

An open source NFT marketplace built on Reservoir.
https://www.reservoir.market
MIT License
173 stars 254 forks source link

[Discussion] Support for universal login with underlying wallet #588

Closed pandurand closed 1 year ago

pandurand commented 1 year ago

Just opening a discussion thread here

We've been looking at the available solutions. Magic looks like one of the most promising candidates for such a feature. We're scoping testing that out for ourselves in the following fashion:

Notes:

@pedromcunha 👇

  1. Have you considered adding support for magic or another provider?
  2. If we engage into building that support, do you have any interest in collaborating on this?
pedromcunha commented 1 year ago

Hi! This seems really interesting, not sure if it's top priority for us or if we'd want to support it in the official OS repo but I can check with the team. I did the bare minimum research here but seems like there's an open source wagmi magic connector: https://github.com/EveripediaNetwork/wagmi-magic-connector

Presumably all you'd need to do is fork the marketplace, install this new dependency and integrate it into _app.tsx. It would just be another login option in the RainbowKit modal.

pandurand commented 1 year ago

Yeah we've looked at the connector you linked and took it for a ride. It's a good starting point but has its limitations and unstable behaviors that we are thinking of addressing. Let me know where your conversation with your team goes 🙏

pedromcunha commented 1 year ago

I see, that's unfortunate. Just spoke with the team given everything we've discussed in this thread and the small amount of research I've done. We're going to hold off on this at least for now until the wagmi-magic-connector package matures a little bit more. Generally we like the idea and think if it could be a straightforward addition that it would fit nicely. If you're willing to get the kinks out of the wagmi-magic-connector then we'll reconsider adding it in, we're just juggling a lot of priorities at the moment.

pandurand commented 1 year ago

Makes sense! I'll close this thread for the moment, and we can reassess later when we'll have made some progress on our end.