reservoirprotocol / marketplace-v1

An open source NFT marketplace built on Reservoir.
https://www.reservoir.market
MIT License
173 stars 254 forks source link

Fix NFT page description meta tags #613

Closed pandurand closed 1 year ago

pandurand commented 1 year ago

Context

The description meta tag is currently not surfaced properly on custom marketplaces that do not provide default meta tags in their configuration.

Two issues were identified. 1 major and 1 minor:

  1. Major issue: the call to meta.description() is erroneous because it relies on the object collection, which is generated asynchronously, and therefore the page does not contain the appropriate tag when first loaded by external services.
  2. Minor issue: the meta.description() function only contains the basic meta tag, but not the twitter and OpenGraph ones.

Taking this opportunity to fix a syntax issue in the title meta tag as well.

Result

Before After
Screen Shot 2022-11-25 at 12 27 00 PM Screen Shot 2022-11-25 at 12 25 31 PM
vercel[bot] commented 1 year ago

@pandurand is attempting to deploy a commit to the Uneven Labs Team on Vercel.

A member of the Team first needs to authorize it.