"array.ptp()" deprecated in numpy 2.0 ("np.ptp(array)" must be use)

reservoirpy / reservoirpy

A simple and flexible code for Reservoir Computing architectures like Echo State Networks

MIT License

415 stars 97 forks source link

Open FrankwaP opened 1 week ago

FrankwaP commented 1 week ago

Bonjour :-)

I think there are two options:

adding "numpy < 2" in the requirements
applying the "np.ptp(array)" fix (1 place + 1 mention in a docstring) and forcing "numpy > 2" in the requirements

I have forked and applied the second fix (to avoid messing with my environment) and it works… so I can make a PR if you wish.

PAUL-BERNARD commented 5 days ago

Thank you for your issue! This has been fixed as this failed the GH Actions tests.

forcing "numpy > 2" in the requirements It shouldn't be necessary, as numpy.ptp has been there for a long time.