search

resetes12 / pokeemerald

Modern Emerald
63 stars 10 forks source link

Fixed Pixilate Effectiveness Issues on Switch-In #15

Closed PinkShellos closed 4 months ago

PinkShellos commented 4 months ago

Description

Addresses Issue #12: Pixilate now appropriately shows its type-effectiveness as well as changes the move's displayed typing in battle menu to make the ability more apparent when Type Effectiveness is set to off.

Created new functions to handle this because displaying the typing requires the use of gActiveBattler to identify the mon, but it doesn't actually change the move type of the attack. Also created separate functions for checking if the ability modifies the move type to make it extensible to potential future abilities that with similar effects (e.g. Refrigerate, Aerilate, Liquid Voice, etc.).

PinkShellos commented 4 months ago

I also think Delcatty getting Pixilate as its ability would be appropriate and make it a bit more viable with its typing. But I won't include it in this PR unless you approve.

resetes12 commented 4 months ago

I'll try to revise it this weekend. Thanks again for your contributions!

PinkShellos commented 4 months ago

Of course! I'm excited to help out and learn! This is my first time coding in C. It's a bit daunting at times, but I've learned a lot so far!