search

resetes12 / pokeemerald

Modern Emerald
63 stars 10 forks source link

Skip "dry battery" message when Fake RTC is enabled. #25

Closed delipunch closed 3 months ago

delipunch commented 3 months ago

If a save exists with the Fake RTC enabled, the game should skip the message about the RTC battery being dry immediately after the title screen, as it's now redundant.

It should specifically check for the save file like that, so on a first boot on an new emulator or flash cart with no RTC functionality, the user can be warned that they'll need the Fake RTC options for time to work in a new file. If a save file has the normal RTC setting, it should still display the message when applicable.

delipunch commented 3 months ago

Changing pokeemerald/src/main_menu.c line 753, from if (!(RtcGetErrorStatus() & RTC_ERR_FLAG_MASK)) to if (!(RtcGetErrorStatus() & RTC_ERR_FLAG_MASK) || gSaveBlock1Ptr->tx_Features_RTCType == 1) should do this, right?

resetes12 commented 3 months ago

Done.

The game now checks if Fake RTC is enabled. If not, it will print the battery dry error (now saying that Fake RTC is recommended with no battery). If it's enabled, it will skip the error.