Correct edge cases for L=A setting

[lain-core]

Resolves #35

Description

Carves out a few of the edge cases where the L button in L=A should be treated as L:

• In the tx_rac_menu, the input is processed to determine the action, but if the user previously set L=A in the settings menu, the case for A_BUTTON is evaluated before the case for L_BUTTON, rendering it impossible to go backwards in the menus. By adding a check for the A_BUTTON case checking that the L_BUTTON was not being pressed simultaneously, we can correctly route the user's input for the menu.

  • This is not relevant for the regular settings in options_plus_menu.c because the A_BUTTON case is not evaluated.

• In the pokemon_summary_screen, on the skills menu, the A button has no effect in the Skills screen otherwise, and L=A users would otherwise be unable to see their Pokemon EVs.

Discord contact info

hking0036

[lain-core]

By the way: I have seen mixed use of checks for the JOY_NEW() macro, and use of gMain.newKeys. Is there a particular reason to use one or the other?

[resetes12]

By the way: I have seen mixed use of checks for the JOY_NEW() macro, and use of gMain.newKeys. Is there a particular reason to use one or the other?

No idea, that question should be asked to PRET as they are the ones who are decompiling Emerald.