search

resetes12 / pokeemerald

Modern Emerald
63 stars 10 forks source link

"Hidden Power" effectiveness is shown incorrectly when "Type effectiveness" is ON #8

Closed resetes12 closed 5 months ago

resetes12 commented 5 months ago

Hidden power works, and shows the correct typing but the "Type effectiveness" option found in the options menu still thinks this move is Normal type. Doesn't affect gameplay in any way.

pokeemerald_modern-0

PinkShellos commented 5 months ago

I'm looking into this now, but I'm not finding where Hidden Power calculates its typing. Could you point to where that is located?

EDIT: Never mind, I found it in battle_script_commands.c. I successfully built it, but I can't test it until I get home from work. If you'd like to check it out and try it, it's on my repo

resetes12 commented 5 months ago

Doesn't seem to work, sadly.

PinkShellos commented 5 months ago

Bummer. I’ll give it another go in a bit.

PinkShellos commented 5 months ago

Just got it working! PR incoming soon!