resgateio / resgate

A Realtime API Gateway used with NATS to build REST, real time, and RPC APIs, where all your clients are synchronized seamlessly.
https://resgate.io
MIT License
689 stars 67 forks source link

Inconsistent timeout units #59

Closed jirenius closed 5 years ago

jirenius commented 5 years ago

Issue

Milliseconds is the timeout unit specified in the RES-service pre-response.

Seconds are used as the requestTimeout unit in Resgate config.

Solution

Change config requestTimeout units to milliseconds.

To ensure acceptable backwards compatibility, if the default timeout setting is >= 10, seconds will be assumed, and a deprecated warning message will show in the log.

Also, the default requestTimeout should be lowered to 3000 ms.