search

reshape / minify

a reshape plugin to minify html output
Other
5 stars 3 forks source link

Removes attributes that contain code nodes #10

Closed jescalan closed 7 years ago

jescalan commented 7 years ago

There's a small bug where reshape-minify will remove attributes that contain code nodes. That is, if you have an attribute that contains an expression as such:

div(class="{{ someLocal }}") hello!

It will be removed as if it were an empty attribute. This issue can be traced back to the removeEmptyAttributes module, which is not properly aware of code nodes.

To learn more about the reshape AST and different types of nodes, check out the docs!

In order to fix this, I'd recommend first setting up a failing test, then diving into the code.

mwickett commented 7 years ago

I think this can be closed because of fcadd2e :)

jescalan commented 7 years ago

Whoo! 🎉