Fix bug with empty attribute removal

reshape / minify

a reshape plugin to minify html output

Other

5 stars 3 forks source link

Fix bug with empty attribute removal #11

Closed mwickett closed 7 years ago

mwickett commented 7 years ago

Only the first value in an attribute was checked for being empty. Caused issue with expressions being removed as empty attributes. Fixed by iterating through each node in attribute and only removing if all are empty.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 914791767f46c1f35f46c47d23123a3837af53ec on mwickett:expression-fix into ec951905ba2061492c1aab8e947b83117892f3f9 on reshape:master.

jescalan commented 7 years ago

🙌